Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach sequence number, publisher GID, and source timestamp to public… #123

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

clalancette
Copy link
Collaborator

…ations.

That way, the subscriptions can pull them out of the attachment and pass it to the upper layers.

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments to optionally address. The changes here will allow us to very easily detect MESSAGE_LOST events!

rmw_zenoh_cpp/src/rmw_zenoh.cpp Show resolved Hide resolved
rmw_zenoh_cpp/src/detail/rmw_data_types.cpp Outdated Show resolved Hide resolved
…ations.

That way, the subscriptions can pull them out of the
attachment and pass it to the upper layers.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette force-pushed the clalancette/pub-seq-num branch from cff4ea0 to fa6f257 Compare March 5, 2024 13:24
@clalancette clalancette merged commit ae14222 into rolling Mar 5, 2024
5 checks passed
@delete-merged-branch delete-merged-branch bot deleted the clalancette/pub-seq-num branch March 5, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants